Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] Fix fingerprinting and loadAllSatelliteResources=true #108190

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

maraf
Copy link
Member

@maraf maraf commented Sep 24, 2024

  • Fix loading fingerprinted satellite assets with loadAllSatelliteResources=true
  • Add WBT test

Fixes #107742

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Sep 24, 2024
@maraf maraf added this to the 10.0.0 milestone Sep 24, 2024
@maraf maraf self-assigned this Sep 24, 2024
@maraf maraf merged commit 6de7e2c into dotnet:main Sep 24, 2024
34 of 38 checks passed
@maraf maraf deleted the BrowserLoadAllSatellites branch September 24, 2024 15:58
@maraf
Copy link
Member Author

maraf commented Sep 24, 2024

/backport to release/9.0

Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/11017525747

maraf added a commit to maraf/runtime that referenced this pull request Sep 24, 2024
maraf added a commit that referenced this pull request Sep 24, 2024
jeffschwMSFT added a commit that referenced this pull request Sep 25, 2024
…ces=true (#108198)

* Set virtualPath for resource show loaded with loadAllSatelliteResources=true

* WBT using loadAllSatelliteResources=true

* Fix passing parameter to test added in #108190

* Update expected test outputs

---------

Co-authored-by: Marek Fišera <mara@neptuo.com>
Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Wasm] Satellite assemblies for localization are not used
3 participants