Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Include browser targets if RID is not wasi-wasm #108283

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

maraf
Copy link
Member

@maraf maraf commented Sep 26, 2024

Because VS publish to container by default set RuntimeIndentifier to linux-x64, we need to treat any non-wasi RID as browser.
This is a runtime part of change, SDK part is in dotnet/sdk#43721.

@maraf maraf merged commit 44c9d13 into dotnet:main Oct 1, 2024
22 of 24 checks passed
@maraf maraf deleted the WasmIncorectRidFromPublishProfile branch October 1, 2024 11:45
@maraf
Copy link
Member Author

maraf commented Oct 1, 2024

/backport to release/9.0

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/11124630497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants