Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use collection syntax in illink #108458

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

use collection syntax in illink #108458

wants to merge 2 commits into from

Conversation

kasperk81
Copy link
Contributor

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Oct 1, 2024
@dotnet-policy-service dotnet-policy-service bot added linkable-framework Issues associated with delivering a linker friendly framework community-contribution Indicates that the PR has been added by a community member labels Oct 1, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

sbomer
sbomer approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! The build errors will be fixed by #108413.

@sbomer
Copy link
Member

sbomer commented Oct 2, 2024

@cston do you know which change introduced the compiler update that broke these tests? They're failing in main due to use of the field keyword. I saw your fix in #108413 but was wondering if it'd be worth updating the ci triggers to run ILLink tests on compiler updates in the future.

This was referenced Oct 3, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbomer sbomer sbomer approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees
No one assigned
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers community-contribution Indicates that the PR has been added by a community member linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasperk81 @sbomer