Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default timeout for launching the browser in WBT #108474

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Oct 2, 2024

Contributes to #107771.
In the worst case launching the browser now will take 90 sec - we have 3 tries. It can prolong the execution of tests but it might also decrease the number of hits in the known issue till we find a real fix.

We always use SpawnBrowserAsync with default parameter value:

IBrowser browser = await runner.SpawnBrowserAsync(url);

and
var browser = await SpawnBrowserAsync(urlString, headless, language: language);

Copy link
Contributor

Tagging subscribers to this area: @directhex, @matouskozak
See info in area-owners.md if you want to be subscribed.

@chcosta
Copy link
Member

chcosta commented Oct 2, 2024

/azp run

Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@chcosta
Copy link
Member

chcosta commented Oct 2, 2024

/azp run runtime

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy ilonatommy merged commit 76772d4 into dotnet:main Oct 3, 2024
22 of 24 checks passed
lambdageek pushed a commit to lambdageek/runtime that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants