Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark or set encoding param in StreamReader ctor to be nullable #108542

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Mark or set encoding param in StreamReader ctor to be nullable #108542

wants to merge 4 commits into from
+18 −24

Commits on Oct 4, 2024

  1. Set encoding param in StreamReader ctor to be nullable

    @eriawan
    eriawan committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    13a5bd4 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. Set additional Encoding param to be nullable and refactor ValidateArg… 

    …sAndOpenPath to not require Encoding param anymore like StreamWriter
    @eriawan
    eriawan committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    2d6377d View commit details
    Browse the repository at this point in the history

  2. Set additional Encoding param to be nullable and refactor ValidateArg… 

    …sAndOpenPath to not require Encoding param anymore like StreamWriter
    @eriawan
    eriawan committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    314fbb5 View commit details
    Browse the repository at this point in the history

  3. Refactor StreamReader_StringCtorTests accordingly as Encoding param h… 

    …as been set to nullable
    @eriawan
    eriawan committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    1d796f1 View commit details
    Browse the repository at this point in the history