JIT: Switch SwiftSelf<T> position requirement to last
#108547
Draft
+39
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is added as the last parameter by the Swift compiler, so to support instance calls taking parameters this needs to come last.
|
Tagging subscribers to this area: @dotnet/interop-contrib |
3 tasks
|
@jkurdek @kotlarmilos any idea on the Mono crash? |
This was referenced Oct 4, 2024
|
I tried reproing the mono failure locally. Both on arm64 and x64. The tests passed without problems. There might be something less obvious going on. I will take another look next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is added as the last parameter by the Swift compiler, so to support instance calls taking parameters this needs to come last.
Fix #107946