Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete STUBLINKER_GENERATES_UNWIND_INFO #108684

Merged
merged 4 commits into from
Oct 12, 2024

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Oct 8, 2024

None of the stublinker stubs need this anymore

@jkotas jkotas changed the title Stublinker generates unwind info @jkotas Delete STUBLINKER_GENERATES_UNWIND_INFO Oct 8, 2024
@jkotas jkotas changed the title @jkotas Delete STUBLINKER_GENERATES_UNWIND_INFO Delete STUBLINKER_GENERATES_UNWIND_INFO Oct 8, 2024
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@AaronRobinsonMSFT
Copy link
Member

@jkotas Is there any impact to R2R for x86?

@jkotas
Copy link
Member Author

jkotas commented Oct 8, 2024

@jkotas Is there any impact to R2R for x86?

This change is no-op for x86. The stub unwind info was not emitted on x86 before this change (both Windows and non-Windows).

@jkotas jkotas force-pushed the STUBLINKER_GENERATES_UNWIND_INFO branch 2 times, most recently from de085ec to 2bc6419 Compare October 9, 2024 04:01
@jkotas jkotas force-pushed the STUBLINKER_GENERATES_UNWIND_INFO branch from 2bc6419 to 618d0d8 Compare October 10, 2024 07:46
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jkotas jkotas merged commit 6fb75bf into dotnet:main Oct 12, 2024
88 of 90 checks passed
@jkotas jkotas deleted the STUBLINKER_GENERATES_UNWIND_INFO branch October 12, 2024 04:20
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants