Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPMI: Use NAOT crossgen2 for collections #109333

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

jakobbotsch
Copy link
Member

@jakobbotsch jakobbotsch commented Oct 29, 2024

Our crossgen2 collections broke with #107772.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 29, 2024
@jakobbotsch
Copy link
Member Author

/azp run runtime-coreclr superpmi-collect-test

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jakobbotsch jakobbotsch marked this pull request as ready for review October 29, 2024 12:10
@jakobbotsch
Copy link
Member Author

All crossgen2 collections succeeded in the test run: https://dev.azure.com/dnceng-public/public/_build/results?buildId=855230&view=results

PTAL @dotnet/jit-contrib

@jakobbotsch jakobbotsch requested a review from a team October 29, 2024 12:10
@jakobbotsch
Copy link
Member Author

/ba-g Build analysis is linking to a dead-lettered log, and I don't see any failures in the console log that the CI pipeline log links to

@jakobbotsch jakobbotsch merged commit c82bd88 into dotnet:main Oct 29, 2024
86 of 88 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants