Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Fix BCE regression #109466

Merged
merged 7 commits into from
Nov 20, 2024
Merged

JIT: Fix BCE regression #109466

merged 7 commits into from
Nov 20, 2024

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Nov 1, 2024

Closes #109365

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 1, 2024
@EgorBo
Copy link
Member Author

EgorBo commented Nov 1, 2024

@MihuBot

@EgorBo EgorBo marked this pull request as ready for review November 3, 2024 13:05
@EgorBo
Copy link
Member Author

EgorBo commented Nov 3, 2024

@EgorBot -intel -arm64 --envvars DOTNET_JitDisasm:Test

using BenchmarkDotNet.Attributes;

public class C
{
    private static readonly int[] _perm = [1, 2, 3, 4];

    private int Index = 1;

    [Benchmark]
    public int Test()
    {
        int index = Index;
        return _perm[index & (_perm.Length - 1)];
    }
}

@EgorBo
Copy link
Member Author

EgorBo commented Nov 18, 2024

PTAL @AndyAyersMS @dotnet/jit-contrib a small change to rely on VN rather than trees in rangecheck pattern. Fixes the regression reported in #109365

@EgorBo EgorBo requested a review from AndyAyersMS November 18, 2024 14:35
@EgorBo EgorBo merged commit d0b4ca6 into dotnet:main Nov 20, 2024
113 of 114 checks passed
@EgorBo EgorBo deleted the fix-bound-check branch November 20, 2024 04:16
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIT: Bound check elimination regression
2 participants