Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up code with NET8_0_OR_GREATER #109507

Merged
merged 6 commits into from
Nov 7, 2024
Merged

Conversation

karakasa
Copy link
Contributor

@karakasa karakasa commented Nov 4, 2024

Contributes to #109226

Libraries targetting only the current framework are checked. Many of the other mentioned libraries target .NET Standard and 6.0, so their #if clauses cannot be removed. Detailed list TBD.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 4, 2024
karakasa and others added 4 commits November 7, 2024 00:23
…neric/ICollectionDebugView.cs

Co-authored-by: xtqqczze <45661989+xtqqczze@users.noreply.github.com>
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@eiriktsarpalis
Copy link
Member

@karakasa any particular reason why this is still in draft? Are there pending changes to be made? If not, we can just merge this.

@karakasa karakasa marked this pull request as ready for review November 7, 2024 13:38
@karakasa
Copy link
Contributor Author

karakasa commented Nov 7, 2024

@karakasa any particular reason why this is still in draft? Are there pending changes to be made? If not, we can just merge this.

I was going to prepare a library list and document which NET8_0_OR_GREATER symbols should remain. Nevertheless, you can merge the PR now.

@akoeplinger akoeplinger merged commit 70c574d into dotnet:main Nov 7, 2024
143 of 146 checks passed
@akoeplinger
Copy link
Member

Thanks!

@karakasa karakasa deleted the issue-109226 branch November 7, 2024 14:02
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure community-contribution Indicates that the PR has been added by a community member
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants