Add GFNI Intrinsics #109537
Merged
Add GFNI Intrinsics #109537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note regarding the |
1 similar comment
|
Note regarding the |
dotnet-policy-service
bot
added
the
community-contribution
saucecontrol
commented
Nov 5, 2024
| if (((cpuFeatures & XArchIntrinsicConstants_Evex) != 0) && | ||
| ((cpuFeatures & XArchIntrinsicConstants_Avx10v1) != 0)) | ||
| { | ||
| if (CLRConfig::GetConfigValue(CLRConfig::EXTERNAL_EnableAVX10v1)) | ||
| { | ||
| CPUCompileFlags.Set(InstructionSet_EVEX); | ||
| CPUCompileFlags.Set(InstructionSet_AVX10v1); | ||
|
|
||
| if((cpuFeatures & XArchIntrinsicConstants_Avx512) != 0) |
There was a problem hiding this comment.
This check wasn't really correct because it looks only at the cpuid bit and not the config knob. However, it doesn't matter anyway because if AVX512 is disabled, AVX10v1_V512 will be removed by implication in the call to EnsureValidInstructionSetSupport.
For simplicity and consistency with the other combo flags to come, I changed it to add the whole set as above, relying on the implications to do their job.
This was referenced Nov 5, 2024
Open
This was referenced Nov 21, 2024
tannergooding
approved these changes
Nov 21, 2024
|
CC. @dotnet/jit-contrib for secondary review -- The JIT format errors are notably unrelated and are under #109987 (comment) |
BruceForstall
approved these changes
Nov 21, 2024
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
* add GFNI intrinsics * add tests * rename file * add missing tests and AOT handling * fix build * fix test result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96170