Don't drop the warning/error code and type when overriding by binlog #109607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilonatommy
added
arch-wasm
pavelsavara
approved these changes
Nov 7, 2024
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #107280.
Is there a test for it?
No, but PR #109069 needs it for
PInvokeTableGeneratorTests(it's checking specifically for e.g.warning.*native function.*sum.*varargsmessage, notnative function.*sum.*varargs, etc). The change was tested there but got separated to decrease the number of changes in that PR.Before the change:
output contains
Found a native function (sum) with varargs in variadic. Calling such functions is not supported, and will fail at runtime. Managed DllImports:After the change:
output contains
/workspaces/runtime/artifacts/bin/dotnet-latest/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/10.0.0-dev/Sdk/WasmApp.Common.targets(793,5): warning WASM0001: Found a native function (sum) with varargs in variadic. Calling such functions is not supported, and will fail at runtime. Managed DllImports: