Unhandled exception handler. #109806

VSadov · 2024-11-14T03:09:50Z

The managed part of #101560
It implements the public static void SetUnhandledExceptionHandler(UnhandledExceptionHandler handler); API

This covers CoreCLR and NativeAOT.
(Mono will need to be addressed separately)

dotnet-issue-labeler · 2024-11-14T03:09:58Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-issue-labeler · 2024-11-14T03:09:59Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-11-14T03:12:06Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

dotnet-policy-service · 2024-11-14T03:12:07Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

VSadov · 2024-11-15T01:32:23Z

Build browser-wasm linux Release LibraryTests is timing out at build stage. It is probably not related to the changes in this PR

VSadov · 2024-11-15T01:35:47Z

I think this is ready for review.

VSadov · 2024-11-15T01:40:42Z

(Mono will need to be addressed separately)

That is because I am far less familiar with where the relevant pieces are in Mono, so I'd like to get CoreCLR/NativeAOT and tests settled.
I may need help with Mono.

src/coreclr/System.Private.CoreLib/src/System/GC.CoreCLR.cs

src/libraries/System.Runtime/ref/System.Runtime.cs

src/tests/baseservices/exceptions/unhandledHandler/HandlerRefuses.cs

src/tests/baseservices/exceptions/unhandledHandler/HandlerThrows.cs

...sts/baseservices/exceptions/unhandledHandler/ForeignThreadRevPInvokeUnhandled/CMakeLists.txt

janvorli · 2024-11-18T20:44:43Z

...unhandledHandler/ForeignThreadRevPInvokeUnhandled/ForeignThreadRevPInvokeUnhandledNative.cpp

+#include <pthread.h>
+#endif // _WIN32
+
+// Work around typedef redefinition: platformdefines.h defines error_t


I wonder if the platformdefines.h should be fixed instead to not to define the error_t and include the errno.h instead.

janvorli · 2024-11-18T20:54:39Z

...ptions/unhandledHandler/ForeignThreadRevPInvokeUnhandled/ForeignThreadRevPInvokeUnhandled.cs

+public class PInvokeRevPInvokeUnhandled
+{
+    [DllImport("ForeignThreadRevPInvokeUnhandled")]
+    public static extern void InvokeCallback(MyCallback callback);


I cannot see this being used in this test

I just copied the file between two tests. One uses InvokeCallback another uses InvokeCallbackOnNewThread. I can remove redundant ones.

src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/__Finalizer.cs

src/tests/baseservices/exceptions/UnhandledExceptionHandler/UnhandledTrivial.cs

…handledTrivial.cs

jkotas

LGTM. Thank you!

VSadov · 2024-11-25T23:59:33Z

The failure in x86 tests is #110127

VSadov · 2024-11-26T00:02:30Z

/ba-g #110127

teo-tsirpanis · 2024-11-26T01:03:23Z

src/libraries/System.Private.CoreLib/src/System/Runtime/ExceptionServices/ExceptionHandling.cs

+
+namespace System.Runtime.ExceptionServices
+{
+    public delegate bool UnhandledExceptionHandler(System.Exception exception);


@VSadov the approved API shape used Func<Exception, bool> instead of a custom delegate.

@VSadov the approved API shape used Func<Exception, bool> instead of a custom delegate.

@VSadov do you have plans to address this? We cannot check in new unapproved public APIs.

Opened #110254.

do you have plans to address this? We cannot check in new unapproved public APIs.

Yes. It was an oversight.
The approved shape was the same as in proposal except for this part. I missed that there was a diff from the proposal.

* unhandled exceptions in Finalizers (Core and AOT) * catch in threadpool * handle in threads * trivial tests * HandlerThrows * HandlerRefuses * NoEffectInMainThread * Rev PInvoke tests * make all pri-0 and disable on mono * use ?. * whitespaces * rename unhandledHandler-->UnhandledExceptionHandler * PR feedback * define error_t as int * ref/System.Runtime formatting * Update src/tests/baseservices/exceptions/UnhandledExceptionHandler/UnhandledTrivial.cs --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com>

dotnet-issue-labeler bot added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Nov 14, 2024

dotnet-policy-service bot assigned VSadov Nov 14, 2024

VSadov force-pushed the unh branch from a3f9ae0 to 8602588 Compare November 14, 2024 03:12

jkotas removed area-VM-coreclr area-NativeAOT-coreclr labels Nov 14, 2024

VSadov marked this pull request as ready for review November 15, 2024 01:35

VSadov requested a review from MichalStrehovsky as a code owner November 15, 2024 01:35

VSadov requested review from jkotas and janvorli and removed request for MichalStrehovsky November 15, 2024 01:35

unhandled exceptions in Finalizers (Core and AOT)

5c15489

VSadov added 5 commits November 15, 2024 08:54

HandlerThrows

d80cd9c

HandlerRefuses

92bc4dc

NoEffectInMainThread

8bd32f2

Rev PInvoke tests

e9aeb09

make all pri-0 and disable on mono

eff45d1

VSadov force-pushed the unh branch from 8602588 to eff45d1 Compare November 15, 2024 16:54

jkotas reviewed Nov 16, 2024

View reviewed changes

janvorli reviewed Nov 18, 2024

View reviewed changes

MichalStrehovsky reviewed Nov 19, 2024

View reviewed changes

src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/__Finalizer.cs Show resolved Hide resolved

VSadov and others added 6 commits November 23, 2024 09:57

use ?.

5b3f13c

whitespaces

4496367

rename unhandledHandler-->UnhandledExceptionHandler

c7833c5

PR feedback

4fd352e

define error_t as int

96ef6e2

ref/System.Runtime formatting

d1ade60

jkotas reviewed Nov 25, 2024

View reviewed changes

src/tests/baseservices/exceptions/UnhandledExceptionHandler/UnhandledTrivial.cs Outdated Show resolved Hide resolved

Update src/tests/baseservices/exceptions/UnhandledExceptionHandler/Un…

fa16227

…handledTrivial.cs

jkotas approved these changes Nov 25, 2024

View reviewed changes

build-analysis bot mentioned this pull request Nov 25, 2024

[wasm] Out of memory exception in System.Xml.XmlWriterApiTests.TCFullEndElement tests #110090

Open

VSadov merged commit 17cb826 into dotnet:main Nov 26, 2024
138 of 140 checks passed

VSadov deleted the unh branch November 26, 2024 00:03

teo-tsirpanis reviewed Nov 26, 2024

View reviewed changes

teo-tsirpanis mentioned this pull request Nov 28, 2024

Update unhandled exception handler API to match approved shape. #110254

Merged

julywint007 mentioned this pull request Nov 28, 2024

https://silver-succotash-5g4jvr76xxxxfvwrw-3000.app.github.dev/ #110255

Closed

SingleAccretion mentioned this pull request Nov 29, 2024

[NativeAOT-LLVM] Post-merge tasks dotnet/runtimelab#2472

Open

mdh1418 mentioned this pull request Dec 10, 2024

Long git directory name causes error C1083 when building coreclr tests (cl.exe) #110407

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unhandled exception handler. #109806

Unhandled exception handler. #109806

VSadov commented Nov 14, 2024 •

edited

Loading

dotnet-issue-labeler bot commented Nov 14, 2024

dotnet-issue-labeler bot commented Nov 14, 2024

dotnet-policy-service bot commented Nov 14, 2024

dotnet-policy-service bot commented Nov 14, 2024

VSadov commented Nov 15, 2024 •

edited

Loading

VSadov commented Nov 15, 2024

VSadov commented Nov 15, 2024 •

edited

Loading

janvorli Nov 18, 2024

janvorli Nov 18, 2024

VSadov Nov 18, 2024

jkotas left a comment

VSadov commented Nov 25, 2024

VSadov commented Nov 26, 2024

teo-tsirpanis Nov 26, 2024 •

edited

Loading

MichalStrehovsky Nov 28, 2024

teo-tsirpanis Nov 28, 2024

VSadov Nov 28, 2024

Unhandled exception handler. #109806

Unhandled exception handler. #109806

Conversation

VSadov commented Nov 14, 2024 • edited Loading

dotnet-issue-labeler bot commented Nov 14, 2024

dotnet-issue-labeler bot commented Nov 14, 2024

dotnet-policy-service bot commented Nov 14, 2024

dotnet-policy-service bot commented Nov 14, 2024

VSadov commented Nov 15, 2024 • edited Loading

VSadov commented Nov 15, 2024

VSadov commented Nov 15, 2024 • edited Loading

janvorli Nov 18, 2024

Choose a reason for hiding this comment

janvorli Nov 18, 2024

Choose a reason for hiding this comment

VSadov Nov 18, 2024

Choose a reason for hiding this comment

jkotas left a comment

Choose a reason for hiding this comment

VSadov commented Nov 25, 2024

VSadov commented Nov 26, 2024

teo-tsirpanis Nov 26, 2024 • edited Loading

Choose a reason for hiding this comment

MichalStrehovsky Nov 28, 2024

Choose a reason for hiding this comment

teo-tsirpanis Nov 28, 2024

Choose a reason for hiding this comment

VSadov Nov 28, 2024

Choose a reason for hiding this comment

VSadov commented Nov 14, 2024 •

edited

Loading

VSadov commented Nov 15, 2024 •

edited

Loading

VSadov commented Nov 15, 2024 •

edited

Loading

teo-tsirpanis Nov 26, 2024 •

edited

Loading