Remove more HelperMethodFrames (HMF) from Reflection #109882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework RuntimeTypeHandle.GetTypeObjectSlow()
and RuntimeFieldHandle.GetApproxDeclaringType()
|
Tagging subscribers to this area: @mangod9 |
jkotas
reviewed
Nov 16, 2024
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
Nov 17, 2024
src/coreclr/System.Private.CoreLib/src/System/RuntimeType.BoxCache.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
RuntimeType.GetParentType for Mono.
AaronRobinsonMSFT
requested review from
thaystg,
steveisok and
vitek-karas
as code owners
jkotas
reviewed
Nov 18, 2024
src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
Outdated
Show resolved
Hide resolved
This was referenced Nov 18, 2024
|
/ba-g Undetected WASM timeouts |
This was referenced Nov 26, 2024
Closed
This was referenced Nov 26, 2024
Closed
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
Convert RuntimeTypeHandle.GetTypeFromHandle() to fast/slow paths. Convert RuntimeTypeHandle.GetBaseType() to RuntimeType.GetParentType() QCall. Consolidate Object.GetType() with RuntimeTypeHandle APIs. Remove HMF from RuntimeFieldHandle.GetAttributes() and RuntimeFieldHandle.GetApproxDeclaringType().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
RuntimeTypeHandle.GetTypeFromHandle()to fast/slow paths.Convert
RuntimeTypeHandle.GetBaseType()to QCall.Consolidate
Object.GetType()withRuntimeTypeHandleAPIs.Remove HMF from
RuntimeFieldHandle.GetAttributes()andRuntimeFieldHandle.GetApproxDeclaringType().Fix nullability on a few Reflection APIs.