Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fold "X relop 0" in assertprop" #110129

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Revert "Fold "X relop 0" in assertprop" #110129

merged 2 commits into from
Nov 25, 2024

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Nov 25, 2024 •
edited
Loading

Reverts #110076

Fixes #110127

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 25, 2024
@jkotas jkotas mentioned this pull request Nov 25, 2024
Closed
EgorBo
EgorBo approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I can confirm locally and see the problem. The bug is in optAssertionProp_RangeProperties so this PR just exposed it, will file a fix

@EgorBo
Copy link
Member

EgorBo commented Nov 25, 2024

/ba-g SPMI failures

@EgorBo EgorBo merged commit da9381e into main Nov 25, 2024
102 of 108 checks passed
EgorBo added a commit to EgorBo/runtime-1 that referenced this pull request Nov 25, 2024
@EgorBo
Reapply "Fold "X relop 0" in assertprop" (dotnet#110129)
9338f4c 
This reverts commit da9381e.
@jtschuster jtschuster mentioned this pull request Nov 25, 2024
Closed
This was referenced Nov 25, 2024
Closed
Closed
Closed
Closed
Closed
EgorBo added a commit that referenced this pull request Nov 25, 2024
@EgorBo
Reapply "Fold "X relop 0" in assertprop" (#110129) (#110142)
f3e28c0
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
@jkotas @mikelle-rogers
Revert "Fold "X relop 0" in assertprop" (dotnet#110129)
28bea0f 
* Revert "Fold "X relop 0" in assertprop (dotnet#110076)"

This reverts commit b5bdce2.

* Dummy edit
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
@EgorBo @mikelle-rogers
Reapply "Fold "X relop 0" in assertprop" (dotnet#110129) (dotnet#110142)
ab635ee
@jkotas jkotas deleted the revert-110076-fold-relops-in-assertprop branch December 13, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgorBo EgorBo EgorBo approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT Awaiting requested review from AaronRobinsonMSFT

Assignees

@jkotas jkotas

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source generator tests failing with NullReferenceException in TaskReplicator
2 participants
@jkotas @EgorBo