Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AltJit for matched VM to also use otherwise unsupported ISAs #110320

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Allow AltJit for matched VM to also use otherwise unsupported ISAs #110320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/coreclr/jit/compiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6042,8 +6042,13 @@ int Compiler::compCompile(CORINFO_MODULE_HANDLE classPtr,
// Note that it might be better to do this immediately when setting the JIT flags in CILJit::compileMethod()
// (when JitFlags::SetFromFlags() is called), but this is close enough. (To move this logic to
// CILJit::compileMethod() would require moving the info.compMatchedVM computation there as well.)
//
// We additionally want to do this for AltJit so that we can validate ISAs that the underlying CPU may
// not support directly. Doing this check later, after opts.altJit has been initialized might be better
// but it requires moving the whole set of logic down into compCompileHelper after compInitOptions has
// run and we're going to end up exiting early if JIT_FLAG_ALT_JIT and opts.altJit don't match anyways

if (!info.compMatchedVM)
if (!info.compMatchedVM || compileFlags->IsSet(JitFlags::JIT_FLAG_ALT_JIT))
{
CORINFO_InstructionSetFlags instructionSetFlags;

Expand Down
Loading