JIT: add more "simple" complexity helpers #110486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In early phases we haven't set tree costs or size estimates, so we fall back to counting statements or nodes. Capture some of this in some helper methods, both pure counting and "exceeds" variants (which are potentially cheaper when comparing against a budget). Update the loop cloning size check to use this.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
@amanasifkhalid PTAL Should be zero diff. I will add more uses of this subsequently. |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
AndyAyersMS
commented
Dec 6, 2024
AndyAyersMS
commented
Dec 6, 2024
Co-authored-by: Aman Khalid <amankhalid@microsoft.com>
This was referenced Dec 6, 2024
|
Hmm, there are a few SPMI diffs. I didn't see these locally. Let me re-check. |
|
There was a loop of size exactly 400, which we now clone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In early phases we haven't set tree costs or size estimates, so we fall back to counting statements or nodes.
Capture some of this in some helper methods, both pure counting and "exceeds" variants (which are potentially cheaper when comparing against a budget).
Update the loop cloning size check to use this.