Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix .cmd scripts help arguments (#1043)" #1110

Merged
merged 1 commit into from
Dec 21, 2019
Merged

Revert "Fix .cmd scripts help arguments (#1043)" #1110

merged 1 commit into from
Dec 21, 2019
+14 −28

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Dec 21, 2019

This reverts commit 0a29c61.

@jkotas
Copy link
Member Author

jkotas commented Dec 21, 2019

Testing for #1097

@jkotas jkotas added the NO-REVIEW Experimental/testing PR, do NOT review it label Dec 21, 2019
@jkotas
Copy link
Member Author

jkotas commented Dec 21, 2019

@safern All PRs are failing with runtime-live-build (Runtime Build Windows_NT x86 release) . Reverting #1043 fixes the failure. I seems that the change broke something about how arguments are passed around.

@jkotas jkotas merged commit 188427d into dotnet:master Dec 21, 2019
@jkotas jkotas removed the NO-REVIEW Experimental/testing PR, do NOT review it label Dec 21, 2019
@jkotas jkotas deleted the revert2 branch December 22, 2019 07:12
@safern
Copy link
Member

safern commented Dec 23, 2019

It seems like the PR to add runtime-live-build was merged while my PR is open and I didn't get coverage for that build on my PR. Will take a look. Thanks for reverting.

@safern safern mentioned this pull request Dec 23, 2019
Merged
z16 pushed a commit to z16/runtime that referenced this pull request Dec 23, 2019
@jkotas @z16
Revert "Fix .cmd scripts help arguments (dotnet#1043)" (dotnet#1110)
a53837e 
This reverts commit 0a29c61.
@jkoritzinsky jkoritzinsky mentioned this pull request Jan 17, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkotas @safern @Dotnet-GitSync-Bot