Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable test based on #129 #130

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Disable test based on #129 #130

merged 1 commit into from
Nov 19, 2019

Conversation

jashook
Copy link
Contributor

@jashook jashook commented Nov 19, 2019 •
edited
Loading

Outerloop tests were just run, this does not need to be re-done as this is expensive.

@jashook jashook added the disabled-test The test is disabled in source code against the issue label Nov 19, 2019
@jashook jashook requested a review from trylek November 19, 2019 21:00
trylek
trylek approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jashook
Copy link
Contributor Author

jashook commented Nov 19, 2019

Merging to save machine cycles

@jashook jashook merged commit 3a2dc0f into dotnet:master Nov 19, 2019
@jashook jashook deleted the disable_based_on_129 branch November 19, 2019 21:17
kouvel added a commit to kouvel/runtime that referenced this pull request Jan 28, 2020
@kouvel
Revert "Disable test based on dotnet#129 (dotnet#130)"
2ef8fe5 
This reverts commit 3a2dc0f.

Fixed by dotnet#1457. Closes dotnet#129.
stephentoub pushed a commit that referenced this pull request Jan 29, 2020
@kouvel
Revert "Disable test based on #129 (#130)" (#2310)
427cd91 
This reverts commit 3a2dc0f.

Fixed by #1457. Closes #129.
jkotas added a commit that referenced this pull request Feb 1, 2020
@jkotas
Revert "Improve call counting mechanism (#1457)" (#30105)
f954c6b 
* Revert "Revert "Disable test based on #129 (#130)" (#2310)"

This reverts commit 427cd91.

* Revert "Fail FuncEval if slot backpatching lock is held by any thread (#2380)"

This reverts commit fc06054.

* Revert "Improve call counting mechanism (#1457)"

This reverts commit 3a457cb.
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trylek trylek trylek approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-coreclr disabled-test The test is disabled in source code against the issue
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jashook @trylek @karelz @Dotnet-GitSync-Bot