Jitstress fixes for tailcall tests #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make STRESS_GENERIC_VARN more compatible with methods that make explicit tail calls. Don't add gc checks for explicit tail calls, and remove the code in morph that blocks tail calls if gc checks are active. Update the tailcall test to to disable STRESS_UNSAFE_BUFFER_CHECKS. This can be reverted when dotnet#314 is merged. Fixes dotnet#1752.
|
cc @dotnet/jit-contrib Also fixes dotnet/coreclr#27658. |
AndyAyersMS
added
area-CodeGen-coreclr
jashook
approved these changes
Jan 15, 2020
BruceForstall
approved these changes
Jan 15, 2020
src/coreclr/src/jit/importer.cpp
Outdated
| // impReturnInstruction: import a return or an explicit tail call | ||
| // | ||
| // Arguments: | ||
| // block -- call returning a struct in a registers |
There was a problem hiding this comment.
"in a registers"? grammar seems weird.
There was a problem hiding this comment.
Yikes, copy paste artifact from the method above.
Looks like block is unused so I'll just remove it entirely and fix up the caller.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make STRESS_GENERIC_VARN more compatible with methods that make explicit tail
calls. Don't add gc checks for explicit tail calls, and remove the code in
morph that blocks tail calls if gc checks are active.
Update the tailcall test to to disable STRESS_UNSAFE_BUFFER_CHECKS. This can
be reverted when
#314#341 is merged.Fixes #1752.