Change debug info default variable tracking system #2107

BrianBohe · 2020-01-23T22:29:43Z

Varible Scope info is being disabled. Variable
Live Range is being enabled. Debug info generated
for debug code is the same, changes only impact on
optimized code.

Variable Live Range updates variable's location
each time something happens to variable's
liveness. For more information see
https://github.com/dotnet/runtime/blob/master/docs/design/features/variabletracking.md

BrianBohe · 2020-01-23T23:55:43Z

I will open an issue to develop a baseline/contract/protocol so we can check no one downgrade/reduce/break debug info on optimize code with future changes.

BrianBohe · 2020-01-23T23:55:56Z

/azp list

azure-pipelines · 2020-01-23T23:56:01Z

Commenter does not have sufficient privileges for PR 2107 in repo dotnet/runtime

BrianBohe · 2020-01-23T23:56:18Z

@BruceForstall

BrianBohe · 2020-01-24T19:02:11Z

@dotnet/jit-contrib

BrianBohe · 2020-01-24T19:02:50Z

@dotnet-bot Test runtime

BruceForstall · 2020-01-24T21:57:54Z

/azp list

azure-pipelines · 2020-01-24T21:57:59Z

CI/CD Pipelines for this repository: coreclr-gc-longrunning coreclr-gc-simulator runtime-coreclr outerloop runtime-coreclr crossgen2 runtime-libraries outerloop runtime-libraries outerloop-windows runtime-libraries outerloop-linux runtime-libraries outerloop-osx runtime runtime-libraries enterprise-linux runtime-libraries stress-http runtime-libraries stress-ssl runtime-live-build runtime-coreclr crossgen2 outerloop coreclr-release-outerloop-nightly sync-runtime-to-mono

BrianBohe · 2020-01-24T22:00:26Z

/azp run runtime

azure-pipelines · 2020-01-24T22:00:31Z

Commenter does not have sufficient privileges for PR 2107 in repo dotnet/runtime

BrianBohe · 2020-01-24T22:58:33Z

/azp run runtime

azure-pipelines · 2020-01-24T22:58:38Z

Commenter does not have sufficient privileges for PR 2107 in repo dotnet/runtime

BrianBohe · 2020-01-24T23:00:01Z

/azp run runtime

azure-pipelines · 2020-01-24T23:00:07Z

Commenter does not have sufficient privileges for PR 2107 in repo dotnet/runtime

BrianBohe · 2020-01-24T23:01:05Z

/azp run runtime

azure-pipelines · 2020-01-24T23:01:14Z

Commenter does not have sufficient privileges for PR 2107 in repo dotnet/runtime

BrianBohe · 2020-01-27T17:35:44Z

/azp list

azure-pipelines · 2020-01-27T17:35:49Z

Commenter does not have sufficient privileges for PR 2107 in repo dotnet/runtime

BrianBohe · 2020-01-27T17:59:42Z

/azp list

azure-pipelines · 2020-01-27T17:59:47Z

Commenter does not have sufficient privileges for PR 2107 in repo dotnet/runtime

BrianBohe · 2020-01-27T19:03:49Z

/azp list

azure-pipelines · 2020-01-27T19:03:54Z

Commenter does not have sufficient privileges for PR 2107 in repo dotnet/runtime

BrianBohe · 2020-01-27T19:04:08Z

/azp list

azure-pipelines · 2020-01-27T19:04:13Z

Commenter does not have sufficient privileges for PR 2107 in repo dotnet/runtime

BrianBohe · 2020-01-27T19:23:16Z

/azp list

BrianBohe · 2020-02-22T11:05:37Z

These were the previous variable ranges

IL Var Num 1:
[rsi [2A , 107 )]
IL Var Num 2:
[rdi [3D , 107 )]
IL Var Num 3:
[rbx [57 , 1EB )]
IL Var Num 4:
[rbp [BA , 1FB )]
IL Var Num 5:
[rsi [121 , 1DC )]
IL Var Num 6:
[rdi [18B , 1A7 )rdi [1A9 , 1DC )]
IL Var Num 7:
[r14 [18E , 1C8 )r14 [1CB , 1E3 )]
IL Var Num 8:
[rbp [59 , 9A )rbp [9C , A0 )]
IL Var Num 9:
[rax [6E , 6E )]
IL Var Num 10:
[r14 [75 , 75 )r14 [79 , 8D )]
IL Var Num 11:
[r14 [BD , FF )r14 [102 , 107 )]
IL Var Num 12:
[rax [D7 , D7 )]
IL Var Num 13:
[r12 [DE , DE )r12 [E1 , F2 )]
IL Var Num 14:
[rdi [123 , 17A )rdi [17C , 189 )]
IL Var Num 15:
[r14 [133 , 169 )r14 [16C , 17A )]
IL Var Num 16:
[r15 [191 , 1CB )r15 [1CE , 1DC )]

and these are new ones

IL Var Num 1:
[rsi [2A , 107 )]
IL Var Num 2:
[rdi [3D , 107 )]
IL Var Num 3:
[rbx [57 , 1EB )]
IL Var Num 4:
[rbp [BA , 1FB )]
IL Var Num 5:
[rsi [121 , 1DC )]
IL Var Num 6:
[rdi [18B , 1DC )]
IL Var Num 7:
[r14 [18E , 1E3 )]
IL Var Num 8:
[rbp [59 , A0 )]
IL Var Num 9:
[rax [6E , 6E )]
IL Var Num 10:
[r14 [75 , 8D )]
IL Var Num 11:
[r14 [BD , 107 )]
IL Var Num 12:
[rax [D7 , D7 )]
IL Var Num 13:
[r12 [DE , F2 )]
IL Var Num 14:
[rdi [123 , 189 )]
IL Var Num 15:
[r14 [133 , 17A )]
IL Var Num 16:
[r15 [191 , 1DC )]

The complete raw output is here

src/coreclr/src/jit/codegencommon.cpp

CarolEidt

A few comments that should be changed, but otherwise LGTM

src/coreclr/src/jit/codegencommon.cpp

src/coreclr/src/jit/emit.cpp

BrianBohe · 2020-02-24T18:21:51Z

Thanks @jkotas and @CarolEidt for the suggestions, I have applied them all. How do we proceed now?

jkotas · 2020-02-24T18:40:39Z

System.Private.CoreLib.dll increases from 9183232 bytes to 9367552 bytes, which is a 2% of growth with my changes.

What is this growth with these fixes?

LGTM otherwise.

BrianBohe · 2020-02-24T19:28:56Z

System.Private.CoreLib.dll increases from 9183232 bytes to 9367552 bytes, which is a 2% of growth with my changes.

What is this growth with these fixes?

LGTM otherwise.
@jkotas, with a Release build:

System.Private.CoreLib.dll increases from 9432064 to 9504256 (~ +0.76 %)
linuxnonjit.dll increases from 1095680 to 1096192 (~ +0.04 %)
superpmi-shim-collector.dll increases from 205312 to 205824 (~ +0.2 %)
clrjit.dll decreases from 1213952 to 1211904 (~ -0.1 %)

BruceForstall · 2020-02-24T23:21:21Z

@briansull Can you please review this from the JIT perspective?

BrianBohe · 2020-02-24T23:23:20Z

/azp help

azure-pipelines · 2020-02-24T23:23:24Z

Supported commands help: Get descriptions, examples and documentation about supported commands Example: help "command_name" list: List all pipelines for this repository using a comment. Example: "list" run: Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run. Example: "run" or "run pipeline_name, pipeline_name, pipeline_name" where: Report back the Azure DevOps orgs that are related to this repository and org Example: "where" See additional documentation.

BrianBohe · 2020-02-24T23:24:45Z

/azp run runtime

azure-pipelines · 2020-02-24T23:25:06Z

Azure Pipelines successfully started running 1 pipeline(s).

briansull · 2020-02-25T03:02:17Z

I reviewed the older code (under #ifdef USING_VARIABLE_LIVE_RANGE)
as this change just enables the new method of recording variable live range debug info.

And I give my approval for checkin.

briansull

Looks Good.

BrianBohe · 2020-02-25T18:14:23Z

@BruceForstall What should we do with the instances failing?

BruceForstall · 2020-02-25T19:12:48Z

@BruceForstall What should we do with the instances failing?

You mean: what about test failures? What kind of failures? It looks like you set them to rerun?

In general, I would rerun until they pass. Unless there are known problems such as documented in #702.

BrianBohe · 2020-02-25T20:07:15Z

@BruceForstall What should we do with the instances failing?

You mean: what about test failures? What kind of failures? It looks like you set them to rerun?

In general, I would rerun until they pass. Unless there are known problems such as documented in #702.

@BruceForstall
I mean the two pipelines: runtime and runtime (Test crossgen-comparison Linux arm checked). Those have been failing since Friday. The logs showed cancellations due to timeouts, errors publishing artifacts that already exists, and I/O errors due to not finding a file. I don't find those cases listed on the issue you provided.

BruceForstall · 2020-02-25T21:10:57Z

@BrianBohe Looks like only crossgen-comparison failed due to infra error. I'd go ahead and merge.

Reverts dotnet#33021, which was a reversion of dotnet#2107. Fix the IG boundary sensitivity for debug emission. Allow debug info to be summarized in a way that makes it amenable to analyze with our jitutils tooling (namely, `jit-analyze`).

jkotas added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 24, 2020

BrianBohe closed this Jan 24, 2020

BrianBohe reopened this Jan 24, 2020

BrianBohe closed this Jan 27, 2020

BrianBohe reopened this Jan 27, 2020

Adding comments

15ecc0b

jkotas reviewed Feb 22, 2020

View reviewed changes

src/coreclr/src/jit/codegencommon.cpp Outdated Show resolved Hide resolved

CarolEidt reviewed Feb 22, 2020

View reviewed changes

src/coreclr/src/jit/codegencommon.cpp Outdated Show resolved Hide resolved

src/coreclr/src/jit/emit.cpp Outdated Show resolved Hide resolved

src/coreclr/src/jit/emit.cpp Outdated Show resolved Hide resolved

src/coreclr/src/jit/emit.cpp Outdated Show resolved Hide resolved

Renaming functions and updating comments

5c4f17d

jkotas approved these changes Feb 24, 2020

View reviewed changes

jkotas mentioned this pull request Feb 24, 2020

SafeHandle use-after-dispose in FileSystemWatcher on OSX #30056

Closed

BruceForstall requested a review from briansull February 24, 2020 23:21

briansull approved these changes Feb 25, 2020

View reviewed changes

jaredpar mentioned this pull request Feb 25, 2020

crossgen-comparison Linux arm checked fails with timeouts #1282

Closed

BrianBohe merged commit 017a64a into dotnet:master Feb 26, 2020

echesakov mentioned this pull request Feb 28, 2020

Test crossgen-comparison Linux arm checked failing #32951

Closed

jkotas mentioned this pull request Mar 1, 2020

Revert "Change debug info default variable tracking system" #33021

Merged

BruceForstall mentioned this pull request Mar 4, 2020

Change debug info tracking system default #33189

Closed

AndyAyersMS mentioned this pull request Jul 7, 2020

Re-enable improvements to debug emission for optimized code #38894

Closed

ghost locked as resolved and limited conversation to collaborators Dec 11, 2020

Change debug info default variable tracking system #2107

Change debug info default variable tracking system #2107

Conversation

BrianBohe commented Jan 23, 2020

BrianBohe commented Jan 23, 2020

BrianBohe commented Jan 23, 2020

azure-pipelines bot commented Jan 23, 2020

BrianBohe commented Jan 23, 2020

BrianBohe commented Jan 24, 2020

BrianBohe commented Jan 24, 2020

BruceForstall commented Jan 24, 2020

azure-pipelines bot commented Jan 24, 2020

BrianBohe commented Jan 24, 2020

azure-pipelines bot commented Jan 24, 2020

BrianBohe commented Jan 24, 2020

azure-pipelines bot commented Jan 24, 2020

BrianBohe commented Jan 24, 2020

azure-pipelines bot commented Jan 24, 2020

BrianBohe commented Jan 24, 2020

azure-pipelines bot commented Jan 24, 2020

BrianBohe commented Jan 27, 2020

azure-pipelines bot commented Jan 27, 2020

BrianBohe commented Jan 27, 2020

azure-pipelines bot commented Jan 27, 2020

BrianBohe commented Jan 27, 2020

azure-pipelines bot commented Jan 27, 2020

BrianBohe commented Jan 27, 2020

azure-pipelines bot commented Jan 27, 2020

BrianBohe commented Jan 27, 2020

BrianBohe commented Feb 22, 2020

CarolEidt left a comment

Choose a reason for hiding this comment

BrianBohe commented Feb 24, 2020

jkotas commented Feb 24, 2020

BrianBohe commented Feb 24, 2020

BruceForstall commented Feb 24, 2020

BrianBohe commented Feb 24, 2020

azure-pipelines bot commented Feb 24, 2020

BrianBohe commented Feb 24, 2020

azure-pipelines bot commented Feb 24, 2020

briansull commented Feb 25, 2020

briansull left a comment

Choose a reason for hiding this comment

BrianBohe commented Feb 25, 2020

BruceForstall commented Feb 25, 2020

BrianBohe commented Feb 25, 2020

BruceForstall commented Feb 25, 2020