Use latest System.Memory for ns2.0 refs #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
approved these changes
Jan 23, 2020
|
Hello @ericstj! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ahsonkhan
reviewed
Jan 24, 2020
| @@ -29,7 +29,7 @@ | |||
| <!-- This is to make sure that nothing unintended gets restored for netcoreapp. --> | |||
| <ItemGroup Condition="'$(TargetFramework)' != '$(NetCoreAppCurrent)'"> | |||
| <!-- runtime dependency: System.Diagnostics.PerformanceCounters netcoreapp2.0,net461 --> | |||
| <PackageReference Include="System.Memory" Version="4.5.2" Condition="'$(TargetFramework)' == 'netcoreapp2.0' or '$(TargetsNetfx)' == 'true' or ('$(TargetsNetStandard)' == 'true' and '$(NETStandardVersion)' >= 1.1)" /> | |||
| <PackageReference Include="System.Memory" Version="4.5.3" Condition="'$(TargetFramework)' == 'netcoreapp2.0' or '$(TargetsNetfx)' == 'true' or ('$(TargetsNetStandard)' == 'true' and '$(NETStandardVersion)' >= 1.1)" /> | |||
There was a problem hiding this comment.
If (or when) a newer version of S.M ships, would we have to update this to that latest version?
There was a problem hiding this comment.
That’s a decision we’d make at the time depending on what the bar was.
joperezr
approved these changes
Jan 25, 2020
Anipik
approved these changes
Jan 25, 2020
|
The failure you're hitting in the tests is already fixed: #2165 Retry won't fix because of the checkout bundle, but if you re-run you shouldn't see it, so up to you. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this regressed here https://github.com/dotnet/corefx/pull/41270/files#r370406355 (likely bad merge resolution).