Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup NETCOREAPP ifdef usage in System.Runtime.Tests #22224

Merged
merged 1 commit into from
Feb 1, 2020
Merged

Cleanup NETCOREAPP ifdef usage in System.Runtime.Tests #22224

merged 1 commit into from
Feb 1, 2020

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Jan 31, 2020

Fixes #21827

@jkotas jkotas added the NO-REVIEW Experimental/testing PR, do NOT review it label Jan 31, 2020
@jkotas
Copy link
Member Author

jkotas commented Jan 31, 2020

I will fix this up to be compatible with platforms that have PNSE reflection.emit.

@jkotas jkotas added area-System.Runtime and removed NO-REVIEW Experimental/testing PR, do NOT review it labels Jan 31, 2020
@jkotas
Copy link
Member Author

jkotas commented Feb 1, 2020

Test failure due to #2209

@safern
Copy link
Member

safern commented Feb 1, 2020 •
edited
Loading

I see another failure also in some System.Net.Tests

*** Error in `/home/helixbot/work/C09809E1/p/dotnet': malloc(): smallbin double linked list corrupted: 0x00007f925c0033f0 ***

https://helix.dot.net/api/2019-06-17/jobs/bcfc4fd7-5e1f-42fb-9345-c19c1543f48f/workitems/System.Net.Security.Tests/console

@jkotas
Copy link
Member Author

jkotas commented Feb 1, 2020

Yeah, there is a assorted variety of crashes on both CoreCLR and Mono. I do not see how this PR could have caused it. It is only updating System.Runtime tests...

I think a bad PR got merged sometime today. I am trying to find it...

@jkotas jkotas mentioned this pull request Feb 1, 2020
Closed
@jkotas jkotas merged commit 483d042 into dotnet:master Feb 1, 2020
@jkotas jkotas deleted the NETCOREAPP branch February 1, 2020 19:34
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern approved these changes

Assignees
No one assigned
Labels
area-System.Runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up if netcoreapp usage in System.Runtime.Tests.
2 participants
@jkotas @safern