-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Crossgen2 a self-contained package #31741
Make Crossgen2 a self-contained package #31741
Conversation
This conflicts with the work in #31701 to move crossgen2 into Arcade along with the rest of the managed components in coreclr. Arcade doesn't support publishing as part of a build as far as I can tell, so that moves crossgen2 to just use the framework-dependent build. |
Also, do we want to publish it as self-contained with the runtime from the sdk we build dotnet/runtime with, or the runtime built as part of the build of dotnet/runtime? This PR currently uses the runtime from the sdk we build dotnet/runtime with. As a result, when building a shipping product, the crossgen2 product would ship with a non-shipping runtime. If we move the packaging steps for crossgen2 up to the installer subset, then we would have enough of the runtime constructed to create a self-contained crossgen2 package using the just-built runtime. This would enable the release package of crossgen2 to ship with a release runtime. |
How do you suggest we fix that? We want to ship crossgen2 as a self-contained package.
We want it to ship using the 5.0 runtime that we'll ship eventually. Sounds like this should move to the installer subset then? |
@jkoritzinsky and I discussed it in person:
|
The packaging project for the package we ship is under the installer sub-repo
To clarify item 3: I'll make the crossgen2 assembly build as framework-dependent, and make the Microsoft.NETCore.App.Crossgen2 package project assemble a self-contained crossgen2 manually with live bits when creating the package. |
We had a discussion about it in our team meeting today and we'll go with a self-contained package for crossgen2 in dotnet5.0
cc @dotnet/crossgen-contrib