-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed heap corruption in HttpListener #33110
Fixed heap corruption in HttpListener #33110
Conversation
/azp run runtime-libraries outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…e even in multi-threaded and multiple Dispose calls.
b89c8fd
to
cfcb23d
Compare
Test failures seem unrelated, can be seen on other PRs as well. Might be fixed with #32827, so rebasing on current master and we'll see. |
Fixes #31997
In non-blocking
HttpListenerResponse.Close
,RequestContextBase
was being disposed multiple times from different threads. This fix ensures that the underlyingIntPtr
is freed only once, even in multi-threaded scenarios.Full explanation here: #31997 (comment)