Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Microsoft.Extensions.DependencyInjection #33816

Merged
merged 11 commits into from
Mar 22, 2020
Merged

Enable Microsoft.Extensions.DependencyInjection #33816

merged 11 commits into from
Mar 22, 2020

Conversation

maryamariyan
Copy link
Member

@maryamariyan maryamariyan commented Mar 19, 2020 •
edited
Loading

Enables DI and Options.

@maryamariyan maryamariyan requested review from ericstj and Anipik March 19, 2020 17:38
@maryamariyan maryamariyan self-assigned this Mar 19, 2020
@maryamariyan maryamariyan mentioned this pull request Mar 19, 2020
Merged
@maryamariyan maryamariyan mentioned this pull request Mar 19, 2020
Closed
safern
safern reviewed Mar 19, 2020
View reviewed changes
...t.Extensions.DependencyInjection/tests/Microsoft.Extensions.DependencyInjection.Tests.csproj
<Reference Include="Microsoft.Extensions.DependencyInjection" />
<Reference Include="Microsoft.Extensions.Logging.Abstractions" />
<Reference Include="Newtonsoft.Json" />
<Compile Include="..\..\Common\tests\Extensions\TestingUtils\Microsoft.AspNetCore.Testing\src\ExceptionAssertions.cs">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this file should/could be converged with the AssertExtensions we have in our Private test utilities.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I'll mark this as todo when I'm cleaning up the unused files. (future PR)

@maryamariyan
Copy link
Member Author

I see mono failure on the CI:
https://helix.dot.net/api/2019-06-17/jobs/97ba643d-68bb-4f46-81a3-a2094e58b3a3/workitems/Microsoft.Extensions.DependencyInjection.Tests/console

@ericstj
Copy link
Member

ericstj commented Mar 20, 2020

This one has a callstack: https://helix.dot.net/api/2019-06-17/jobs/80e913aa-a462-4f20-be32-a4a2e16fc14c/workitems/Microsoft.Extensions.DependencyInjection.Tests/console

@maryamariyan
Enables DI and Options
e6bb861 
- Moves files under DI/tests/Common to Logging/tests/DI.Common as they are Logging tests
- Simplifies and enables DI test csproj
- TODO: Fix test on "ServiceCollectionServiceExtensionsTest.cs"
@maryamariyan
TODO: fix
307b2e0
maryamariyan and others added 6 commits March 20, 2020 14:52
@maryamariyan
Copy link
Member Author

resolved conflict by rebase.

@ericstj ericstj mentioned this pull request Mar 21, 2020
Closed
@ericstj
Copy link
Member

ericstj commented Mar 21, 2020

Mono failure is #32377. I'm seeing this on all recent builds, so I don't think it's related to this change.

@maryamariyan maryamariyan merged commit 110804e into dotnet:master Mar 22, 2020
@davidfowl
Copy link
Member

👏

@maryamariyan maryamariyan mentioned this pull request Jun 12, 2020
Closed
11 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern left review comments

@ericstj ericstj ericstj approved these changes

@Anipik Anipik Awaiting requested review from Anipik

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@EgorBo EgorBo Awaiting requested review from EgorBo

@marek-safar marek-safar Awaiting requested review from marek-safar

@steveisok steveisok Awaiting requested review from steveisok

@vargaz vargaz Awaiting requested review from vargaz

Assignees

@maryamariyan maryamariyan

Labels
area-Extensions-DependencyInjection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maryamariyan @ericstj @davidfowl @steveisok @safern @Dotnet-GitSync-Bot