You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it's possible to run stress tests on privately built CoreCLR and libraries by executing load-corefx-testhost.ps1 -b followed by run-docker-compose.ps1 -b. However, it was not possible to run the stress server on a private Asp.Net Core package which is used for private libraries build.
This PR adds a new -pa parameter to run-docker-compose.ps1 which builds a server container with a private Asp.Net Core package version.
Think what ever is under eng/* should be submitted to arcade project (and than that's roll in automatically)
The stress pipeline (and the enterprise-linux pipeline) don't run in Helix or use Arcade at all. They simply define a new pipeline directly and run it either manually or triggered by pushes/commits to the branch.
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I would recommend you manually invoke the stress tests pipelines in this PR to validate it. Currently the stress tests aren't automatically invoked for every PR.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
locked as resolved and limited conversation to collaborators
Currently, it's possible to run stress tests on privately built CoreCLR and libraries by executing
load-corefx-testhost.ps1 -bfollowed byrun-docker-compose.ps1 -b. However, it was not possible to run the stress server on a private Asp.Net Core package which is used for private libraries build.This PR adds a new
-paparameter torun-docker-compose.ps1which builds a server container with a private Asp.Net Core package version.