Unset repo tools manifest path in CI to fix restore errors #33871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
force-pushed
the
RepoToolsSdkFix
branch
from
a100946 to
af575b3
Compare
safern
reviewed
Mar 20, 2020
eng/Tools.props
Outdated
| @@ -2,6 +2,9 @@ | |||
| <PropertyGroup> | |||
| <MSBuildTreatWarningsAsErrors>false</MSBuildTreatWarningsAsErrors> | |||
| <EnableAnalyzers>true</EnableAnalyzers> | |||
| <!-- Unset the repo tool manifest property in CI as we don't use repo tools there anyway, | |||
| until https://github.com/dotnet/sdk/issues/10938 is fixed. --> | |||
| <_RepoToolManifest /> | |||
There was a problem hiding this comment.
The comment says in CI, however, this operation is not conditioned to CI.
An updated SDK with the net5.0 tfm change seems to break dotnet repo tool restore, presumably because multiple compatible tfms are found. Working around this by deleting the repo tools manifest file until the issue is fixed.
ViktorHofer
force-pushed
the
RepoToolsSdkFix
branch
from
af575b3 to
337576f
Compare
safern
approved these changes
Mar 20, 2020
|
Here's the official build: https://dnceng.visualstudio.com/internal/_build/results?buildId=567300 |
cc @dotnet/dnceng |
ViktorHofer
changed the title
|
@dotnet/runtime-infrastructure Feel free to merge after CI has completed. I believe the current failures are all unrelated. I'm logging off now but can take a look tomorrow if the PR isn't merged by then. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An updated SDK with the net5.0 tfm change seems to break dotnet repo
tool restore, presumably because multiple compatible tfms are found.
Working around this by unsetting the repo tools manifest file path until the
issue is fixed.
Fixes #33837
cc @stephentoub