Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSharpCodeGenerator tests #33886

Merged
merged 3 commits into from
Sep 21, 2020
Merged

Add CSharpCodeGenerator tests #33886

merged 3 commits into from
Sep 21, 2020

Conversation

hughbe
Copy link
Contributor

@hughbe hughbe commented Mar 20, 2020

Proposed Changes

  • Add CSharpCodeGenerator tests

@hughbe hughbe force-pushed the Add-CSharpCodeGenerator-tests branch from ca4aadb to 695ccf9 Compare March 20, 2020 23:27
@jaredpar jaredpar mentioned this pull request Mar 21, 2020
Closed
@hughbe hughbe force-pushed the Add-CSharpCodeGenerator-tests branch from 695ccf9 to 4d394dc Compare May 3, 2020 10:49
@hughbe hughbe force-pushed the Add-CSharpCodeGenerator-tests branch 2 times, most recently from 6782698 to c0d30fa Compare May 9, 2020 21:02
@hughbe hughbe force-pushed the Add-CSharpCodeGenerator-tests branch 3 times, most recently from e59241d to c42ceb2 Compare May 18, 2020 09:35
@jaredpar jaredpar mentioned this pull request May 18, 2020
Closed
@hughbe hughbe force-pushed the Add-CSharpCodeGenerator-tests branch 2 times, most recently from af75a27 to aa4039c Compare May 24, 2020 08:50
@hughbe hughbe force-pushed the Add-CSharpCodeGenerator-tests branch from aa4039c to bb40f8c Compare June 1, 2020 10:08
@hughbe hughbe force-pushed the Add-CSharpCodeGenerator-tests branch 2 times, most recently from d5222f2 to f2d5329 Compare June 17, 2020 10:06
@buyaa-n buyaa-n added this to the 6.0.0 milestone Jun 22, 2020
@hughbe hughbe force-pushed the Add-CSharpCodeGenerator-tests branch 5 times, most recently from 591677c to bd10d57 Compare July 10, 2020 12:26
@hughbe hughbe force-pushed the Add-CSharpCodeGenerator-tests branch from bd10d57 to 9166462 Compare July 11, 2020 10:36
@hughbe hughbe force-pushed the Add-CSharpCodeGenerator-tests branch from 9166462 to 22b27d0 Compare August 20, 2020 10:27
@hughbe hughbe force-pushed the Add-CSharpCodeGenerator-tests branch from 22b27d0 to b4e117a Compare September 12, 2020 13:48
buyaa-n
buyaa-n approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hughbe for your contribution, this is a huge work for improving our test coverage

@buyaa-n buyaa-n merged commit e489111 into dotnet:master Sep 21, 2020
@hughbe hughbe deleted the Add-CSharpCodeGenerator-tests branch September 21, 2020 19:22
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@buyaa-n buyaa-n buyaa-n approved these changes

@stephentoub stephentoub stephentoub left review comments

Assignees
No one assigned
Labels
area-System.CodeDom
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hughbe @stephentoub @buyaa-n @Dotnet-GitSync-Bot