Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set osOverride default value to empty on mono builds #33987

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

safern
Copy link
Member

@safern safern commented Mar 23, 2020

I was looking at one mono build and noticed that for legs that don't set this value, a $(osOverride) literal is passed down to the scripts. Builds don't fail, but logs look weird and there is also a error in the script:
mono.cmd -configuration debug -arch x64 $(osOverride) -ci /p:MonoEnableLLVM=false

osOverride : The term 'osOverride' is not recognized as the name of a cmdlet, function, script file, or operable 
program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:92
+ ... bsetCategory mono -configuration debug -arch x64 $(osOverride) -ci /p ...
+                                                        ~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (osOverride:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

Author:    Santiago Fernandez Madero <safern@microsoft.com>
@safern safern force-pushed the OsOverrideDefaultValue branch from ff9f956 to 6368774 Compare March 23, 2020 23:13
@safern
Copy link
Member Author

safern commented Mar 24, 2020

Failure is: #33928

@safern safern merged commit 5208633 into dotnet:master Mar 24, 2020
@safern safern deleted the OsOverrideDefaultValue branch March 24, 2020 20:29
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants