-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CI to run CoreCLR tests on Mono #34054
Conversation
author Joseph Shields <directhex@apebox.org> 1583952716 -0400 committer Nathan Ricci <naricc@microsoft.com> 1586815263 -0400 Add Mono run of CoreCLR Pri0 tests Changes to exclude mono failures. build-test-job.yml Changes to runtime.yml Changes to runtime.yml Got rid of parameter. Removed parameter. reverse changesin runtime. Simplified some things. Combined mono/clore build-test-job.yml into one file in common. Removed onld build-test-job.yml Removed white space. Missing parens. Removed undeed mono build-test-job. Removed run-test-job.yml Added build-job back; still needed. Added back a change that got lost in merge. Got rid of compile time evaluation of runtime stuff. Moved xplat-pipeline-job to common. Updated paths. More path updates. Moved xplat-job. Undid file moves. Refer to different templates based on runtime parameters. reverted changes to build-job. Updated build-test-job. Moved to a mono version of run-test-job. Back to seperate versions of run-test-job.yml Added back mono version of run-test-job.yml Moved references to common version of build-test. Build test job.yml Moved send-to-helix-step to common. Removed mono specific send-to-helix-step. Moved run-test-job.yml into common. Fixed run-test-job. Fixed run test job again. Fixed run test job again. Fixed run test job again. Removed mono specific version of run-test-job. Removed windows from mono coreclr test platforms until that script is written. Added some variables to mono version of xplat-job. Made building tests depend explicitly on coreclr. Made mono also get CoreCLR. Fixed spacing. Fixed syntax error. build-test-job.yml Changed dispaly name. Changed dispaly name. Fixed variable name. Fixed white space. Testing some yml. Reversed changes. Removed - Used each. Add liveRuntimeBuildConfig parameter. Add liveRuntimeBuildConfig parameter. removed redundant definition. removed redundant definition. removed redundant paramter. Fixed typos, display names. Added display name. Use display name. Added missing : Fixed spelling errors. Fixed spelling error. Fixed spelling error. Canged CoreCLRProductBuild to always use release Use display name. Commented out other architecturs for debugging. Added runtimeFlavorDisplayName explicitly in runtime.yml Added missing variables to mono version of xplat-pipeline job Put in missing variables. More missing variables. More missing variables. Changed hardcoded release. Added liveRuntimeBuildConfig. Changed to parameter. Changed to parameter. Trying to make everything build in release. Messing with different configs. Made everything checked. Added runtime flavor to run-test-job name. Fixed spelling on parameters. Made all the mono stuff build in debug. Made more things debug. Changed everything to release. Made everthing release, again. Changed to run test job. Added missing space. run-test-job.yml Fixed msbuild invocation. Pushing a white space change. Removed white space change. Removed unneeded single quotes.
ff4658d
to
822a7be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than pending comments LGTM.
@naricc This change has broken at least the jitstress pipeline: https://dev.azure.com/dnceng/public/_build/results?buildId=613103&view=results with: |
Opened #35367 to track. |
I believe that was fiuxed by: #35311 |
Enable CorCLR tests to run on Mono. To do this we also refactor parts of the build .yml to reduce code duplication; instead of having seperate mono/coreclr versions that are 90 % the same.