Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EnumerableViewOfDispatch.GetEnumerator ref counting #34230

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Fix EnumerableViewOfDispatch.GetEnumerator ref counting #34230

merged 1 commit into from
Mar 30, 2020

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Mar 28, 2020 •
edited
Loading

This function would end up increasing the ref count via Variant.ToObject and Marshal.GetIUnknownForObject, but not decreasing it, thus leaking the object.

Fixes #32747

@elinor-fung elinor-fung merged commit b95caba into dotnet:master Mar 30, 2020
@elinor-fung elinor-fung deleted the enumerableIDispatch-refCount branch March 30, 2020 18:27
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

@jkoritzinsky jkoritzinsky Awaiting requested review from jkoritzinsky

Assignees
No one assigned
Labels
area-Interop-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leak when using NetFwTypeLib in .Net Core 3.1
2 participants
@elinor-fung @AaronRobinsonMSFT