Eliminate dead configuration code #34285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. Please help me learn by adding exactly one area label. |
jkotas
reviewed
Mar 30, 2020
cshung
force-pushed
the
dev/andrewau/config
branch
from
ab739ff to
c12ee97
Compare
cshung
changed the title
cshung
changed the title
cshung
force-pushed
the
dev/andrewau/config
branch
2 times, most recently
from
fa3386b to
810350b
Compare
cshung
force-pushed
the
dev/andrewau/config
branch
from
810350b to
43833bd
Compare
cshung
changed the title
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the work trying to understand #12948. I figured that the
ConfigListdata structure is never populated, so I proposed this PR to eliminate all the code related to it.Any code that accesses
ConfigListwill never get anything useful, so I eliminated those code paths.After the removal, some functions will always return
E_FAIL, so we can also eliminate the function completely and patch to call sites to not call them.A good deal of code is removed because of that :)
@jkotas, this is ready to be merged.