Enhance PAL initialization order #34308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CGroups initialization has _ASSERTE that is not asserting because debugging support was being initialized after the CGroups initialization. This change moves the debugging support initialization to the earliest possible point. It also modifies it so that it doesn't depend on the PAL env functions and uses getenv instead. And finally, initialization of the critical section for debug printf is moved to the very end of DBG_init_channels just as a little cleanup.
jkotas
reviewed
Mar 31, 2020
jkotas
approved these changes
Mar 31, 2020
jkotas
reviewed
Mar 31, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CGroups initialization has _ASSERTE that is not asserting because
debugging support was being initialized after the CGroups initialization.
This change moves the debugging support initialization to the earliest
possible point. It also modifies it so that it doesn't depend on the
PAL env functions and uses getenv instead. And finally, initialization
of the critical section for debug printf is moved to the very end
of DBG_init_channels just as a little cleanup.