Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NativeCallable bugfixes #34335

Merged
merged 1 commit into from
Mar 31, 2020
Merged

NativeCallable bugfixes #34335

merged 1 commit into from
Mar 31, 2020

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Mar 31, 2020

  • Fix race condition in JIT_ReversePInvokeEnter
  • Disable R2R for x86 on all platforms

@jkotas
NativeCallable bugfixes
239feca 
- Fix race condition in JIT_ReversePInvokeEnter
- Disable R2R for x86 on all platforms
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 31, 2020
@jkotas
Copy link
Member Author

jkotas commented Mar 31, 2020

These are bug fixes from the large native callable change that was rolled back.

AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jkotas jkotas merged commit a9ace0f into dotnet:master Mar 31, 2020
@jkotas jkotas deleted the nativecallable-bugfixes branch March 31, 2020 19:07
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkotas @AaronRobinsonMSFT @Dotnet-GitSync-Bot