Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add profiler tests to the runtime repo #34411

Merged
merged 4 commits into from
Apr 3, 2020
Merged

Add profiler tests to the runtime repo #34411

merged 4 commits into from
Apr 3, 2020

Conversation

davmason
Copy link
Member

@davmason davmason commented Apr 1, 2020

Ports GCBasic, ReJIT, and EventPipe tests as well as adds a test that verifies profilers can call MetaDataGetDispenser.

@davmason davmason requested review from noahfalk and a team April 1, 2020 18:17
@davmason davmason self-assigned this Apr 1, 2020
noahfalk
noahfalk approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me David : ) I'd recommend adding a little README that describes the basics of how these tests work and how someone could run one in isolation if they need to.

test_repro.sh Outdated Show resolved Hide resolved
@jaredpar jaredpar mentioned this pull request Apr 2, 2020
Closed
@davmason davmason merged commit c21c7fd into dotnet:master Apr 3, 2020
@AndyAyersMS AndyAyersMS mentioned this pull request May 13, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas left review comments

@noahfalk noahfalk noahfalk approved these changes

Assignees

@davmason davmason

Labels
area-Diagnostics-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davmason @noahfalk @jkotas @Dotnet-GitSync-Bot