Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove -runtime version suffix hack for M.E. #34464

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Remove -runtime version suffix hack for M.E. #34464

merged 1 commit into from
Apr 3, 2020

Conversation

maryamariyan
Copy link
Member

@maryamariyan maryamariyan requested review from ericstj and joperezr April 2, 2020 16:07
joperezr
joperezr approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, thanks @maryamariyan. I suppose we have now removed them from building in the extensions repo?

@maryamariyan
Copy link
Member Author

yes we removed them

@maryamariyan
Copy link
Member Author

failure is unrelated and reported inhttps://github.com//pull/34467

@maryamariyan maryamariyan merged commit 221f869 into dotnet:master Apr 3, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joperezr joperezr joperezr approved these changes

@ericstj ericstj ericstj approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maryamariyan @ericstj @joperezr @Dotnet-GitSync-Bot