Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add savepoint API to DbTransaction #34561

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Add savepoint API to DbTransaction #34561

merged 1 commit into from
Aug 5, 2020

Conversation

roji
Copy link
Member

@roji roji commented Apr 5, 2020 •
edited
Loading

Closes #33397

Note that I've continued the general ADO.NET pattern of having the default implementation of async methods fall back to the sync methods. This also means that the default NotSupportedException gets returned as a failed task rather than a synchronous thrown exception.

@Dotnet-GitSync-Bot
Copy link
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@roji roji mentioned this pull request Apr 5, 2020
Closed
@roji
Copy link
Member Author

roji commented Apr 5, 2020

Based on the bot's gentle reminder, added triple-slash comments with documentation for the new APIs. Last time I did this, I had to submit a separate PR to https://github.com/dotnet/dotnet-api-docs - has some automatic sync been put into place? If not it may be better not to have the docs here and worry about keeping them in sync...

@roji roji force-pushed the SystemDataSavepoints branch from 0853334 to b8118e7 Compare April 21, 2020 11:27
@jaredpar jaredpar mentioned this pull request Apr 21, 2020
Closed
@roji roji force-pushed the SystemDataSavepoints branch from b8118e7 to aa23e4f Compare July 31, 2020 11:44
@roji
Copy link
Member Author

roji commented Jul 31, 2020

Rebased and made the proper modifications after approval of the design proposal (#33397).

@roji roji requested a review from ajcvickers July 31, 2020 11:45
@roji
Copy link
Member Author

roji commented Aug 5, 2020

@ajcvickers ping

@roji roji merged commit 8250b0a into dotnet:master Aug 5, 2020
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@roji @Jacksondr5
Add savepoint API to DbTransaction (dotnet#34561)
3ab805f 
Closes dotnet#33397
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@am11 am11 am11 left review comments

@ajcvickers ajcvickers ajcvickers approved these changes

@bgrainger bgrainger bgrainger approved these changes

Assignees
No one assigned
Labels
area-Infrastructure new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose transaction savepoints in ADO.NET
5 participants
@roji @Dotnet-GitSync-Bot @bgrainger @ajcvickers @am11