-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable some disabled warnings in CoreCLR #34659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Ivan for your tenacity in fighting GitHub quirks! Please just make sure to use a squash merge to spare us the details of your fight ;-).
There are still some warnings that cause build break in the GCC build:
|
Those are new! Let me take a look and fix them. Thanks for pointing them out Jan. |
This is a followup to PR #33902, which has been reviewed and approved. The reason for this new PR, is that Azure Pipelines tests got stuck and the solution was to get the latest changes. When rebasing the branch with master, all those commits and changes were added to the PR, thus rendering it entirely uninformative, and therefore useless for historic study and statistics.
Fixes #33743.
Added some necessary casts and fixed string formats to comply with warnings 4302, 4311, 4312, and 4477 in CoreCLR. Having these warnings back on will help improve code quality and reduce potential scenarios where unpredicted behavior might cause further issues.