Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arg aliases for runtimeConfiguration and librariesConfiguration #34743

Merged
merged 2 commits into from
Apr 10, 2020

Conversation

safern
Copy link
Member

@safern safern commented Apr 9, 2020

I feel like people type a lot just to pass in either runtimeConfiguration or librariesConfiguration to the build scripts.

This also fixes the help text as -r is not supported in powershell for restore as powershell takes it as the runtimeConfiguration because it matches substrings on parameters.

Fixes: #2172

cc: @stephentoub @jkotas @dotnet/runtime-infrastructure

@ghost
Copy link

ghost commented Apr 9, 2020

Tagging @ViktorHofer as an area owner

@safern safern force-pushed the AddConfigurationAliases branch from b566fad to 3b2b99e Compare April 9, 2020 05:39
@jkotas
Copy link
Member

jkotas commented Apr 9, 2020

On Windows, the shortcuts work already, as long as they are non-ambiguous - Powershell feature. So the following works on Windows today, even without this change:

build -s clr+libs -ru checked -c Release

Should we just use the shortcuts that you naturally get on Windows for Unix as well?

@safern
Copy link
Member Author

safern commented Apr 9, 2020

Should we just use the shortcuts that you naturally get on Windows for Unix as well?

Yeah that Powershell feature is handy, however, the reason why I chose adding -rc and -lc, is because it is more natural, usually short form of script arguments are the initials of the works that compose the full name and when reading a command it is easier for the reader to relate -rc to runtimeConfiguration than -ru as -ru the only relation it has, is that is the first two letters of the script.

Also, adding a short form for -subset in Unix does makes a lot of sense.

@safern
Copy link
Member Author

safern commented Apr 9, 2020

@jkotas do you agree on merging this as is?

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. It would be nice to have -s shortcut for subsets.

@safern
Copy link
Member Author

safern commented Apr 9, 2020

It would be nice to have -s shortcut for subsets.

Yeah. I'll update before merging.

@safern safern merged commit 8640eed into dotnet:master Apr 10, 2020
@safern safern deleted the AddConfigurationAliases branch April 10, 2020 01:09
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-runtimeConfiguration breaks -r as a shortcut for restore on build.ps1
4 participants