-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arg aliases for runtimeConfiguration and librariesConfiguration #34743
Conversation
Tagging @ViktorHofer as an area owner |
b566fad
to
3b2b99e
Compare
On Windows, the shortcuts work already, as long as they are non-ambiguous - Powershell feature. So the following works on Windows today, even without this change:
Should we just use the shortcuts that you naturally get on Windows for Unix as well? |
Yeah that Powershell feature is handy, however, the reason why I chose adding -rc and -lc, is because it is more natural, usually short form of script arguments are the initials of the works that compose the full name and when reading a command it is easier for the reader to relate -rc to runtimeConfiguration than -ru as -ru the only relation it has, is that is the first two letters of the script. Also, adding a short form for -subset in Unix does makes a lot of sense. |
@jkotas do you agree on merging this as is? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. It would be nice to have -s
shortcut for subsets.
Yeah. I'll update before merging. |
I feel like people type a lot just to pass in either runtimeConfiguration or librariesConfiguration to the build scripts.
This also fixes the help text as -r is not supported in powershell for restore as powershell takes it as the runtimeConfiguration because it matches substrings on parameters.
Fixes: #2172
cc: @stephentoub @jkotas @dotnet/runtime-infrastructure