Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native configurations for SunOS #34756

Merged
merged 1 commit into from
Apr 11, 2020
Merged

Add native configurations for SunOS #34756

merged 1 commit into from
Apr 11, 2020

Conversation

am11
Copy link
Member

@am11 am11 commented Apr 9, 2020

  • grep does not support -o or -m options (only GNU-derived grep do)
    • replace grep -o with awk matching pattern, that works with Linux, macOS and BSD alike.
    • replace find $dir | grep -m 1 key with find $dir -name key | head -n1
  • add basic configurations to get passed libraries and coreclr cmake configuration steps.
    • installer build succeeds with this change and the previously merged PR:
      src/installer/corehost/build.sh -apphostver 5.0.0-dev -hostver 5.0.0-dev -fxrver 5.0.0-dev -policyver 5.0.0-dev -commithash $(git rev-parse HEAD) -gcc

Contributes to: #4173

@ghost
Copy link

ghost commented Apr 9, 2020

Tagging @ViktorHofer as an area owner

@jkotas
Copy link
Member

jkotas commented Apr 10, 2020

Could you please take a look at the conflicts?

@am11
Copy link
Member Author

am11 commented Apr 11, 2020

Rebased and resolved merge conflicts.
Some legs are pending for 15 hours (#34832).

##[error]We stopped hearing from agent NetCorePublic-Pool 31. Verify the agent machine is running and has a healthy network connection. Anything that terminates an agent process, starves it for CPU, or blocks its network access can cause this error. For more information, see: https://go.microsoft.com/fwlink/?linkid=846610

@jkotas jkotas merged commit 4d3b5e5 into dotnet:master Apr 11, 2020
@am11 am11 deleted the feature/solaris/configuration branch April 11, 2020 16:43
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants