Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] iOS Test runner #34976

Merged
merged 15 commits into from
Apr 17, 2020
Merged

[mono] iOS Test runner #34976

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f9a926e
Prototype
EgorBo Apr 14, 2020
4f0100e
Move Microsoft.DotNet.XHarness.Tests.Runners to versions.prop
EgorBo Apr 15, 2020
07bc7cd
Update dotnet-tools.json
EgorBo Apr 15, 2020
7148281
Address feedback
EgorBo Apr 15, 2020
625b9cc
use dylibs for simulator
EgorBo Apr 15, 2020
fadf3e5
add aotdata (for aot)
EgorBo Apr 15, 2020
7b30a9c
Fix scrolling
EgorBo Apr 15, 2020
15a4e65
Update src/mono/msbuild/AppleTestRunner/AppleTestRunner.cs
EgorBo Apr 16, 2020
b04617b
Address feedback
EgorBo Apr 16, 2020
7af4801
Fix nullability in SimpleTestRunner
EgorBo Apr 16, 2020
780b1fb
Update Microsoft.XmlSerializer.Generator.Tests.csproj
EgorBo Apr 16, 2020
2a5f6bf
Add SystemNative_InitializeTerminalAndSignalHandling to pal_log
EgorBo Apr 16, 2020
2a61ec9
Undo Console.ios changes
EgorBo Apr 16, 2020
487d9d0
fix typo
EgorBo Apr 16, 2020
c26cf8b
Disable data-outfile again
EgorBo Apr 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions src/mono/msbuild/AppleTestRunner/AppleTestRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,21 @@

public class SimpleTestRunner : iOSApplicatonEntryPoint, IDevice
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOSApplicatonEntryPoint -- is this a typo? iOSApplicationEntryPoint

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, it's in dotnet/xharness. I didn't know about this repo 😸

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @mandel-macaque ^

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, while you are there could you please add events for "test is started", "test is finished (with result)" ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danmosemsft I'm known for my typos, I'll get that fixed! @EgorBo dotnet/xharness#36

{
private static List<string> testLibs;
private static List<string> testLibs = new List<string>();

public static async Task<int> Main(string[] args)
{
// Redirect all Console.WriteLines to iOS UI
Console.SetOut(new AppleConsole());
Console.WriteLine($"ProcessorCount = {Environment.ProcessorCount}")
Console.WriteLine($"ProcessorCount = {Environment.ProcessorCount}");

Console.Write("Args: ");
foreach (string arg in args)
{
Console.Write(arg);
}
Console.WriteLine(".");

testLibs = new List<string>();
foreach (string arg in args.Where(a => a.StartsWith("testlib:")))
{
testLibs.Add(arg.Remove(0, "testlib:".Length));
Expand Down Expand Up @@ -62,7 +62,7 @@ public static async Task<int> Main(string[] args)

protected override IEnumerable<TestAssemblyInfo> GetTestAssemblies()
{
foreach (string file in testLibs)
foreach (string file in testLibs!)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the null forgiving operator needed here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@safern I forgot to remove it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix it in the next PR

{
yield return new TestAssemblyInfo(Assembly.LoadFrom(file), file);
}
Expand All @@ -79,21 +79,21 @@ protected override void TerminateWithSuccess()

protected override TestRunnerType TestRunner => TestRunnerType.Xunit;

protected override string IgnoreFilesDirectory { get; }
protected override string? IgnoreFilesDirectory { get; }

public string BundleIdentifier => "net.dot.test-runner";

public string UniqueIdentifier { get; }
public string? UniqueIdentifier { get; }

public string Name { get; }
public string? Name { get; }

public string Model { get; }
public string? Model { get; }

public string SystemName { get; }
public string? SystemName { get; }

public string SystemVersion { get; }
public string? SystemVersion { get; }

public string Locale { get; }
public string? Locale { get; }
}

internal class AppleConsole : TextWriter
Expand Down