Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unit test to provoke exception using Sch_WhiteSpaceRestriction… #35013

Merged
merged 10 commits into from
May 11, 2020
Merged

Adding unit test to provoke exception using Sch_WhiteSpaceRestriction… #35013

merged 10 commits into from
May 11, 2020

Conversation

mrj001
Copy link
Contributor

@mrj001 mrj001 commented Apr 15, 2020

@buyaa-n
Per your suggestion in PR#33890, I'm using a second pull request.

This contains my attempt to provoke the exception using Sch_WhiteSpaceRestriction1 as its message. However, it is provoking a different exception:
image

I suspect this is a bug, as the XSD I'm trying to compile differs from the example in Paragraph 4.3.6 only in the name of the type and the presence of the namespace qualifier. (I'm pretty sure I've got the correct version of the spec now. :-))

The active test case is attempting to determine what was going wrong. The commented out test case is the one to actually try to provoked the exception.

Fixes #30218:

@ghost
Copy link

ghost commented Apr 15, 2020

Tagging subscribers to this area: @buyaa-n
Notify danmosemsft if you want to be subscribed.

@mrj001
Copy link
Contributor Author

mrj001 commented Apr 23, 2020

@buyaa-n
I was not happy with my suspicion of a bug, so I kept looking at it.
I found my problem with the schema in the PR - I had a lower-case "s" in "whiteSpace". That was so hard to see, but now the error message makes sense.

@buyaa-n
Copy link
Contributor

buyaa-n commented Apr 26, 2020

I was not happy with my suspicion of a bug, so I kept looking at it.
I found my problem with the schema in the PR - I had a lower-case "s" in "whiteSpace". That was so hard to see, but now the error message makes sense.

That happens 😄, glad that you found it, thank you for your continuous effort. seems now you need to fix the tests and resolve conflict

@mrj001
Copy link
Contributor Author

mrj001 commented Apr 27, 2020

@buyaa-n
Tests are fixed. Conflict is resolved.

This PR now covers the final 3 of the 13 string resources in Issue #30218:

  • Sch_WhiteSpaceRestriction1
  • Sch_WhiteSpaceRestriction
  • Sch_AttributeRestrictionInvalidFromWildcard

Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mrj001, it looks great, sorry for the delayed review

@buyaa-n
Copy link
Contributor

buyaa-n commented May 8, 2020

This PR now covers the final 3 of the 13 string resources in Issue #30218:

Great, then we should add fixes #30218 in the definition, so that it get closed automatically after merge

@buyaa-n buyaa-n merged commit 23e13a3 into dotnet:master May 11, 2020
@krwq
Copy link
Member

krwq commented May 11, 2020

Thanks @mrj001!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xml resources have invalid formatter
4 participants