Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IAsyncDisposable for XmlWriter #35233

Merged
merged 14 commits into from
Apr 28, 2020
Merged

Implement IAsyncDisposable for XmlWriter #35233

merged 14 commits into from
Apr 28, 2020

Conversation

buyaa-n
Copy link
Contributor

@buyaa-n buyaa-n commented Apr 21, 2020

Fixes #29464
Related to #33618

@buyaa-n buyaa-n added this to the 5.0 milestone Apr 21, 2020
@buyaa-n buyaa-n requested review from krwq and stephentoub April 21, 2020 06:09
@ghost
Copy link

ghost commented Apr 21, 2020

Tagging subscribers to this area: @buyaa-n, @krwq
Notify danmosemsft if you want to be subscribed.

@Dotnet-GitSync-Bot
Copy link
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@jaredpar jaredpar mentioned this pull request Apr 21, 2020
Closed
@buyaa-n buyaa-n mentioned this pull request Apr 23, 2020
Closed
@buyaa-n buyaa-n force-pushed the async_writer_close branch from 6114231 to 2f04d5d Compare April 26, 2020 18:50
@jaredpar jaredpar mentioned this pull request Apr 27, 2020
Closed
@buyaa-n
Copy link
Contributor Author

buyaa-n commented Apr 28, 2020

All feedbacks addressed please let me know if there is anything else in your mind @bartonjs @krwq @stephentoub, thanks!

@krwq
Copy link
Member

krwq commented Apr 28, 2020

LGTM with some questions

krwq
krwq approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify if test change is needed. Product code LGTM

@buyaa-n
Copy link
Contributor Author

buyaa-n commented Apr 28, 2020

Thank you @krwq gonna merge it now, if anyone has other feedback please feel free to add it later and I can re-iterate that separately

@buyaa-n buyaa-n merged commit 77fab0b into dotnet:master Apr 28, 2020
This was referenced Apr 28, 2020
Closed
Closed
@ericstj ericstj mentioned this pull request Apr 29, 2020
Closed
@buyaa-n buyaa-n mentioned this pull request Sep 21, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
@buyaa-n buyaa-n deleted the async_writer_close branch December 10, 2020 07:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bartonjs bartonjs bartonjs left review comments

@stephentoub stephentoub stephentoub left review comments

@krwq krwq krwq approved these changes

Assignees
No one assigned
Labels
area-System.Xml new-api-needs-documentation
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

XDocument.SaveAsync has a blocking call
5 participants
@buyaa-n @Dotnet-GitSync-Bot @krwq @stephentoub @bartonjs