-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop passing in auto-discovered xunit traits #35237
Merged
ViktorHofer
merged 6 commits into
dotnet:master
from
ViktorHofer:XUnitFrameworkPlatformDynamic
Apr 22, 2020
Merged
Stop passing in auto-discovered xunit traits #35237
ViktorHofer
merged 6 commits into
dotnet:master
from
ViktorHofer:XUnitFrameworkPlatformDynamic
Apr 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With dotnet/arcade#5314, framework and platform traits don't need to be passed in manually anymore. Also removing the obsolete vstest.runner.json as it isn't needed for VSTest.
Tagging subscribers to this area: @ViktorHofer |
stephentoub
approved these changes
Apr 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming it all works :)
akoeplinger
approved these changes
Apr 21, 2020
safern
approved these changes
Apr 21, 2020
Failures are because of dotnet/arcade#5322. |
am11
reviewed
Apr 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes dotnet/arcade#4105
With dotnet/arcade#5314, framework and platform
traits don't need to be passed in manually anymore. Also removing the
obsolete vstest.runner.json as it isn't needed for VSTest.