Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop passing in auto-discovered xunit traits #35237

Merged
merged 6 commits into from
Apr 22, 2020

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Apr 21, 2020

Closes dotnet/arcade#4105

With dotnet/arcade#5314, framework and platform
traits don't need to be passed in manually anymore. Also removing the
obsolete vstest.runner.json as it isn't needed for VSTest.

With dotnet/arcade#5314, framework and platform
traits don't need to be passed in manually anymore. Also removing the
obsolete vstest.runner.json as it isn't needed for VSTest.
@ghost
Copy link

ghost commented Apr 21, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming it all works :)

@ViktorHofer
Copy link
Member Author

Failures are because of dotnet/arcade#5322.

@ViktorHofer ViktorHofer merged commit 7eaa8b1 into dotnet:master Apr 22, 2020
@ViktorHofer ViktorHofer deleted the XUnitFrameworkPlatformDynamic branch April 22, 2020 12:43
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TargetOSTrait to be available in non-CoreFX repos
6 participants