Updated assert statement to include a check for Timeout in FileSystem… #35298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….Attributes.Windows
|
Tagging subscribers to this area: @jozkee |
|
Fixes #28831 |
danmoseley
approved these changes
Apr 22, 2020
|
@vivekbm if you edit your top comment to add the line |
Added the check, the earlier commit had a syntax error.
stephentoub
approved these changes
Apr 22, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28831
There is a test failure in System.IO.FileSystem.Tests and since the root cause appears to be OS specific, the instruction is to update the assert statement to catch the semaphore timeout case.