Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address the System.Diagnostics Feedback #35582

Merged
merged 6 commits into from
May 3, 2020
Merged

Address the System.Diagnostics Feedback #35582

merged 6 commits into from
May 3, 2020

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Apr 28, 2020

This change mainly addresses @stephentoub feedback on the PR #35326.

@ghost
Copy link

ghost commented Apr 28, 2020

Tagging subscribers to this area: @tarekgh, @tommcdon
Notify danmosemsft if you want to be subscribed.

@tarekgh tarekgh requested review from noahfalk and stephentoub April 28, 2020 19:02
@tarekgh
Copy link
Member Author

tarekgh commented Apr 28, 2020

@noahfalk part of the change, we now keep the order of the tags, baggage, and links as it got added. I consider this not a breaking change. Please advise if you think otherwise.

noahfalk
noahfalk approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments inline, otherwise LGTM

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs Outdated Show resolved Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs Show resolved Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs Outdated Show resolved Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs Show resolved Hide resolved
@ericstj ericstj mentioned this pull request Apr 29, 2020
Closed
@tarekgh
Copy link
Member Author

tarekgh commented Apr 30, 2020

@stephentoub are you ok to merge it now?

stephentoub
stephentoub approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@tarekgh
Copy link
Member Author

tarekgh commented May 1, 2020

Thanks @stephentoub for your review and feedback. I addressed all of them as you have suggested.

@tarekgh tarekgh merged commit 150f0d7 into dotnet:master May 3, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
@tarekgh tarekgh deleted the SystemDiagnosticsAPIs-Feedback branch March 15, 2021 19:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noahfalk noahfalk noahfalk approved these changes

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-System.Diagnostics.Tracing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tarekgh @stephentoub @noahfalk @Dotnet-GitSync-Bot