-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Vector128 and Vector256.Create methods #35857
Merged
Merged
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
97f40a4
Updating Vector128.Create(T value) to be intrinsic
tannergooding f89e85f
Updating Vector128.Create(T, ..., T) to be intrinsic
tannergooding 0056c5f
Updating Vector256.Create(T) and Vector256.Create(T, ..., T) to be in…
tannergooding 8a5a12e
Applying formatting patch
tannergooding ef8ec3f
Merge remote-tracking branch 'dotnet/master' into const-vector
tannergooding fdf297f
Adding additional comments explaining how the Vector128.Create and Ve…
tannergooding 9376428
Add an assert that argCnt is as expected for LowerHWIntrinsicCreate
tannergooding 96d9199
Applying formatting patch
tannergooding 781cc04
Use unsigned rather than signed types in LowerHWIntrinsicCreate
tannergooding c90baf3
Have HWIntrinsicInfo::lookupId take the number of arguments into account
tannergooding 6f3511b
Merge remote-tracking branch 'dotnet/master' into const-vector
tannergooding 67f1b1f
Adjusting Vector128.Create(T, ..., T) to not be recursive on ARM64
tannergooding c056b88
Fixing MyICJI::allocMem in superpmi to respect certain CorJitAllocMem…
tannergooding 51c7d28
Avoid an implicit downcast
tannergooding File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you chose not to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not something we are handling today anywhere else and we have an identical
TODO
in the other places.I believe this would just require us creating a
GT_IND
node since x86 requires it be along*
orulong*
, but I'm not positive if that is the ideal/correct way to handle itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting, this is also not something we are handling in the managed implementation today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I gathered that, but was just curious, given the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super familiar with the differences between the different addressing forms in the JIT and when each is appropriate to use.
Do we have a helper function that will create a
T*
orref T
from an arbitraryT
(In this case aulong*
from aulong
) when the given operand on the stack could be a constant, local, field, byref, or other indirection?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC you really want a
GT_ADDR
, to get the address of an operand. I the JIT addresses are not strongly typed, they are alwaysTYP_BYREF
, so it would just be something like:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though I'd note that I'm not really pressing for you to do this now - I was just curious why you added the comment rather than doing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll attempt this in a follow up PR, hopefully it is that straightforward 😄