Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Arm64] ASIMD Rename AddReturningHighNarrow to AddHighNarrow #35919

Merged
merged 7 commits into from
May 7, 2020
Merged

[Arm64] ASIMD Rename AddReturningHighNarrow to AddHighNarrow #35919

merged 7 commits into from
May 7, 2020

Conversation

echesakov
Copy link
Contributor

Follow up on #32512 (comment) after the API review on 5/5/2020 - renaming:

  • AddReturningHighNarrow -> AddHighNarrow
  • AddReturningRoundedHighNarrow -> AddRoundedHighNarrow
  • SubtractReturningHighNarrow -> SubtractHighNarrow
  • SubtractReturningRoundedHighNarrow -> SubtractRoundedHighNarrow

No functional changes

@tannergooding @CarolEidt PTAL

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 6, 2020
@echesakov echesakov added area-System.Runtime.Intrinsics and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels May 6, 2020
@ghost
Copy link

ghost commented May 6, 2020

Tagging subscribers to this area: @tannergooding
Notify danmosemsft if you want to be subscribed.

CarolEidt
CarolEidt approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@CarolEidt CarolEidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@echesakov
Copy link
Contributor Author

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@echesakov echesakov merged commit 08b244e into dotnet:master May 7, 2020
@echesakov echesakov deleted the Arm64-ASIMD-Rename-Add-Subtract-HighNarrow-RoundedHighNarrow branch May 7, 2020 17:30
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tannergooding tannergooding tannergooding approved these changes

@CarolEidt CarolEidt CarolEidt approved these changes

Assignees
No one assigned
Labels
arch-arm64 area-System.Runtime.Intrinsics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@echesakov @CarolEidt @tannergooding @Dotnet-GitSync-Bot