mark native files in RuntimeList.xml as "DropFromSingleFile" unless from a specific list of known files.

[VSadov]

mark native files in RuntimeList.xml as "DropFromSingleFile" unless from a specific list of known files.

[ghost]

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

[jkoritzinsky]

I believe this change needs to be made in the Arcade version of this task. I think the one in this repo is dead code.

cc: @dagood

Here’s the arcade version: https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk/src/CreateFrameworkListFile.cs

[VSadov]

Thanks!!
I will copy the change and add a comment here that this is dead copy. I assume it is needed, since it is here.

[dagood]

This should be done similarly to ReferencedByDefault (or metadata on Files or something), not hard-coded into the build task itself, so that putting it into Arcade doesn't prevent quickly changing it in dotnet/runtime. (Also makes the data easier to find.)

[VSadov]

When it was supposed to be entirely in runtime, it could be more convenient to keep the logic in one place.
If this needs to go into arcade, I guess adding it as metadata on Files could make sense.

[dagood]

Is there an issue associated with this?

/cc @NikolaMilosavljevic

[VSadov]

cc: @swaroop-sridhar

[VSadov]

The associated issue: dotnet/sdk#11567

[swaroop-sridhar]

I believe this change needs to be made in the Arcade version of this task. I think the one in this repo is dead code.

cc: @dagood

Here’s the arcade version: https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk/src/CreateFrameworkListFile.cs

Can we remove this file from the runtime repo? Or is there a reason to keep them here too?

[dagood]

It's already gone. #35405